Remove StringContext attribute #498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
commented
Apr 4, 2024
| @@ -1115,18 +1117,9 @@ To <dfn abstract-op export>get Trusted Types-compliant attribute value</dfn> on | |||
| # Integrations # {#integrations} | |||
|
|
|||
| <pre class="idl"> | |||
| typedef [StringContext=TrustedHTML] DOMString HTMLString; | |||
There was a problem hiding this comment.
Need to remember to update the HTML, Dom Parser, and Sanitiser API specs to use union types instead.
There was a problem hiding this comment.
As of w3c/DOM-Parsing#82 DOM Parsing spec will no longer contain any TT sinks.
There was a problem hiding this comment.
Not sure it's worth another PR to the sanitiser api, when they're upstreaming they'll get the idea what's going on (especially given Anne has played a part in both specs)
lukewarlow
commented
Apr 15, 2024
lukewarlow
force-pushed
the
update-idl
branch
2 times, most recently
from
8310136
to
0a79b5b
Compare
Swap to using a union type and updating the algorithms directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap to using a union type and updating the algorithms directly.
Need #457 merged first as this removes usages of StringContext
Corresponding HTML PR: whatwg/html#10286 (whatwg/html#10328)
Corresponding Sanitizer PR: TODO
Preview | Diff