Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in MediaSeqTiming002.xml #303

Open
palemieux opened this issue Dec 23, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@palemieux
Copy link
Contributor

commented Dec 23, 2017

Timing Test - Seq - 002 implies that the following p is not shown:

<p begin="00:00:05:00">This text must not appear.</p>

TTML1 however states that the implicit duration of the anonymous span This text must not appear. is indefinite. As a result, the implicit duration of the p is also indefinite (in contrast with the inline comment default duration for elements in this context is 0), and the contents of the anonymous span will be shown.

@palemieux palemieux added the question label Dec 23, 2017

@nigelmegitt

This comment has been minimized.

Copy link
Contributor

commented Dec 23, 2017

I concur - the test is wrong as it stands. Furthermore the following p whose text begins "This text must appear at 35 seconds" will never appear.

@skynavga

This comment has been minimized.

Copy link
Contributor

commented Dec 23, 2017

@palemieux I agree, since the parent p is not sequential (by default). I suggest a fix by adding timeContainer="seq" to the parent p.

@nigelmegitt the p you refer to does not follow the p that @palemieux refers to.

@nigelmegitt

This comment has been minimized.

Copy link
Contributor

commented Dec 23, 2017

@skynavga thanks, the two similar divs confused me. However the only fault was that I missed one of the error cases. I make it that the following issues exist with the test as a result of the implicit duration of the anonymous span being indefinite:

  • the last <p> in each <div> never appears because the immediately preceding <p> has an indefinite implicit duration, so its text is incorrect.
  • the penultimate <p> in each <div> does in fact appear, despite containing text saying that it does not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.