Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of font selection strategy in line height algorithm. #1102

Closed
nigelmegitt opened this issue May 28, 2019 · 2 comments · Fixed by #1106
Closed

Use of font selection strategy in line height algorithm. #1102

nigelmegitt opened this issue May 28, 2019 · 2 comments · Fixed by #1106

Comments

@nigelmegitt
Copy link
Contributor

Currently the tts:fontSelectionStrategy attribute is not listed in the algorithm for normal in tts:lineHeight but since that algorithm (step 4) is based on actual fonts chosen, it should be.

Algorithm should take include tts:fontSelectionStrategy

The algorithm for computing the used value at https://www.w3.org/TR/ttml2/#style-attribute-lineHeight lists in step 4:

the computed values of the tts:fontStyle, tts:fontWeight, and tts:fontVariant style properties of P.

This should additionally include tts:fontSelectionStrategy.

Consistency of referencing back to the algorithm.

tts:fontFamily and tts:fontWeight and
tts:fontVariant all include text like:

In addition to applying to span, the computed value of this property on a p element is used to resolve the normal value of the style property associated with the tts:lineHeight attribute as specified in 10.2.27 tts:lineHeight.

This should be added to tts:fontSelectionStrategy

@skynavga skynavga changed the title lineHeight normal algorithm and fontSelectionStrategy Use of font selection strategy in line height algorithm. May 30, 2019
@skynavga skynavga self-assigned this May 30, 2019
@skynavga skynavga added this to the 2ED-FPWD milestone May 30, 2019
@skynavga
Copy link
Collaborator

skynavga commented May 30, 2019

Marking this as editorial since the semantics of font selection strategy already require its (explicit) use (if the property is supported) in the determination of the selected font from a list of fonts specified in tts:fontFamily even though it is not at present explicitly listed in step (4) of the line height algorithm. If someone feels strongly the other way (that this is a substantive change), then I will consider changing to substantive.

@skynavga
Copy link
Collaborator

Actually, addressing the second part of this issue will require a substantive change, so I'm changing this back to substantive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants