Metadata attributes apply as well as elements #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1271 Also made a grammar fix where plurals "Any metadata" and "Any parameters" had singular "applies" form of the verb - replaced with plural "apply".
|
The Timed Text Working Group just discussed
The full IRC log of that discussion<nigel> Topic: Metadata attributes apply as well as elements #1273<nigel> github: https://github.com//pull/1273 <nigel> SUMMARY: Review needed |
skynavga
requested changes
Jun 6, 2024
Intended to address @skynavga 's review comments
skynavga
approved these changes
Jun 8, 2024
|
LGTM |
|
@cconcolato do you want to review also, or shall I go ahead and merge this? |
cconcolato
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1271 by specifying that metadata attributes apply semantically as well as metadata elements, on those elements that accept metadata attributes.
In passing, also made a grammar fix where plurals "Any metadata" and "Any parameters" had singular "applies" form of the verb - replaced with plural "apply".