Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote all keywords in value syntax expression definitions. #587

Closed
skynavga opened this issue Jan 25, 2018 · 5 comments
Closed

Quote all keywords in value syntax expression definitions. #587

skynavga opened this issue Jan 25, 2018 · 5 comments

Comments

@skynavga
Copy link
Collaborator

For example, auto should be written "auto".

@skynavga skynavga self-assigned this Jan 25, 2018
@skynavga
Copy link
Collaborator Author

This change is intended to address the potential for ambiguous reading of identifier tokens, and, as such, is an editorial change since it does not change the intended or actual syntax.

@skynavga
Copy link
Collaborator Author

In addition, change any tokens that use ' delimiter to use " delimiter.

@skynavga skynavga removed their assignment Jan 30, 2018
@skynavga skynavga added this to the Post CR1 milestone Feb 2, 2018
@nigelmegitt
Copy link
Contributor

I think this applies only to attribute value syntax, in other words there is no need to modify the XML Representations of elements. @skynavga do you agree?

@nigelmegitt
Copy link
Contributor

nigelmegitt commented Feb 2, 2018

Arguing for modifying XML Representations of elements as well as attribute value syntax, consider for example: §6.1.5 ttp:extension has an XML Representation that includes the adjacent lines:

  value = (optional|required|use|prohibited) : see prose below
  xml:id = ID

I suppose there could be ambiguity about whether xml:id should have the value ID or be an identifier, given that the value attribute takes one of four string keywords that are listed.

As part of this issue it could be modified to:

  value = ("optional" | "required" | "use" | "prohibited") : see prose below
  xml:id = ID

Doing this across the whole spec will take a while...

@nigelmegitt
Copy link
Contributor

I've answered the question for myself: yes, it should include XML Representations of elements. Will push a fix for that in a moment.

skynavga added a commit that referenced this issue Feb 7, 2018
@skynavga skynavga added pr merged and removed pr open labels Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants