Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos. #678

Closed
11 tasks done
skynavga opened this issue Feb 24, 2018 · 11 comments
Closed
11 tasks done

Fix typos. #678

skynavga opened this issue Feb 24, 2018 · 11 comments

Comments

@skynavga
Copy link
Collaborator

skynavga commented Feb 24, 2018

Need to fix the following typos:

  • in Table E-1, #background should be marked for version 2, not 1;
  • in Table E-1, #background-image should be marked for version 2, not 1;
  • in Table E-1, #contentProfiles should be marked as mandatory, not optional;
  • in Table E-1, #inferProcessorProfile should be marked as mandatory, not optional;
  • in Table E-1, #permitFeatureNarrowing should be marked as mandatory, not optional;
  • in Table E-1, #permitFeatureWidening should be marked as mandatory, not optional;
  • in Table E-1, #transformation-version-2 should be marked for version 2, not 1;
  • in profiles/ttml2-{presentation,transformation}.xml, #core should follow #contentProfiles;
  • in E.1.161, tts:rubyAlign-withBase should be changed to tts:rubyAlign and the href fragment id similarly updated.
  • update Table E-2 to match what is in Table E-1;
  • update Table E-3 to match what is in Table E-1;

Check off as added to some PR.

@skynavga skynavga added this to the CR1 milestone Feb 24, 2018
@skynavga skynavga self-assigned this Feb 24, 2018
skynavga added a commit that referenced this issue Feb 25, 2018
@nigelmegitt
Copy link
Contributor

nigelmegitt commented Feb 26, 2018

@skynavga Why should the profile-related features be marked as mandatory not optional? This is non-obvious.

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 26, 2018

@nigelmegitt They already are (in the profiles docs), this PR is just to make the table consistent. As for why, #profile was mandatory in TTML1, so #profile-version-2 is mandatory in TTML2. This has been in the previous WDs, so not new here.

@nigelmegitt
Copy link
Contributor

@skynavga it might not be new, but it is not obviously correct.

#profile was significantly simpler than #profile-version-2 - why does the latter need to be mandatory?

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 26, 2018

Because #profile-version-2 is required to obtain TTML2 profile semantics. Can we just fix the editorial problem that this issue documents rather than discussing the rationale for the feature being required, which is orthogonal. You can raise that as different issue for CR2.

@nigelmegitt
Copy link
Contributor

Can we just fix the editorial problem that this issue documents

Not really, because folk like me might have taken the alternate view that the error was in the profile document (i.e. in appendix G.2).

Because #profile-version-2 is required to obtain TTML2 profile semantics.

@skynavga Right, but that's not an argument that it must be listed as a required feature in table E-1 and appendix G.2.

The question to ask here is: if a [transformation | presentation] processor were not to implement, say, #contentProfiles, could it still process some useful set of document instances? There is a significant class of processors targeted at a specific usage such as players in a vertical platform, that simply do not need to support those profile-related feature designators, and that can process the features they do understand.

By marking the features as required, my concerns are that a) such processors could not be classed as TTML2 processors and b) someone could argue that they should be excluded from the implementation report.

@nigelmegitt
Copy link
Contributor

Add to this issue: E.1.161 #rubyAlign-withBase refers to the style attributes tts:rubyAlign-withBase with an href that points to #style-attribute-rubyAlign-withBase - in both cases that looks like a copy/past error and the -withBase part should be deleted.

@skynavga
Copy link
Collaborator Author

@nigelmegitt the simple fact that they are listed in the profile documents is sufficient evidence that table E-1 is incorrect; we can either fix this editorial inconsistency now and then address the issue of whether we want things this way separately in CR2 or we can do nothing now and go out the door with an easily fixed inconsistency;

@nigelmegitt
Copy link
Contributor

@skynavga why do you assert priority of Appendix G.2 over Table E-1?

@skynavga
Copy link
Collaborator Author

skynavga commented Feb 27, 2018

@nigelmegitt I assert that Appendix G was changed and that the corresponding changes in E-1 were inadvertently left out; priorities don't matter

@nigelmegitt
Copy link
Contributor

I've raised #683 - if we resolve in favour of that issue then some of the changes requested here will not be needed.

@skynavga
Copy link
Collaborator Author

skynavga commented Mar 7, 2018

@nigelmegitt re: #678 (comment), any resolution to #683 will be after CR1 is published

skynavga added a commit that referenced this issue Mar 9, 2018
@skynavga skynavga removed their assignment Mar 9, 2018
@skynavga skynavga added pr merged and removed pr open labels Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants