Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing feature designators. #679

Closed
skynavga opened this issue Feb 24, 2018 · 4 comments
Closed

Add missing feature designators. #679

skynavga opened this issue Feb 24, 2018 · 4 comments

Comments

@skynavga
Copy link
Collaborator

skynavga commented Feb 24, 2018

Add missing feature designation #unicodeBidi-version-2.

@skynavga skynavga added this to the CR2 milestone Feb 24, 2018
@skynavga skynavga self-assigned this Feb 24, 2018
@nigelmegitt
Copy link
Contributor

@skynavga Why is this needed given that we already have #unicodeBidi-isolate that deals with the values not already handled by #unicodeBidi?

@skynavga
Copy link
Collaborator Author

@nigelmegitt for consistency, since we are defining *-version-2 designations when we have extensions to existing features; more specifically, #unicodeBidi does not include #unicodeBidi-isolate, so we need a new (includes everything old + new) designation as we've done elsewhere, e.g., #animation-version-2, #bidi-version-2, etc.

@nigelmegitt
Copy link
Contributor

@skynavga OK, that makes sense. From an implementation perspective it there any reason why someone might support #unicodeBidi-isolate but not #unicodeBidi?

@skynavga
Copy link
Collaborator Author

@nigelmegitt no, but the former does not logically require the latter, and vice versa

@skynavga skynavga changed the title Add missing feature designations. Add #unicodeBidi-version-2 feature designator. May 17, 2018
@skynavga skynavga changed the title Add #unicodeBidi-version-2 feature designator. Add missing feature designators. May 21, 2018
skynavga added a commit that referenced this issue May 31, 2018
…ature

Add #unicodeBidi-version-2 feature designator (#679).
@skynavga skynavga removed their assignment May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants