Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTML feature(s) for rw/rh <length> units #718

Closed
spoeschel opened this issue Apr 26, 2018 · 3 comments
Closed

Add TTML feature(s) for rw/rh <length> units #718

spoeschel opened this issue Apr 26, 2018 · 3 comments

Comments

@spoeschel
Copy link

The rw and rh units can be used in <length> expressions and were added by TTML2. However they are currently not covered by a respective TTML feature - in contrast to the other allowed units of <length> (e.g. #length-em for the em unit).

@nigelmegitt
Copy link
Contributor

I agree these should be added. TTML2's #length differs from TTML1's #length because of the changes to <length>, so there's an immediate problem to resolve. I think we need three things:

  1. define a #length-rwrh (or similar) feature
  2. define the TTML2 #length to be the same as the TTML1 #length by referencing the subset of features that were required in TTML1 only.
  3. define a new #length-version-2 to include all the TTML2 <length>-related features.

@spoeschel
Copy link
Author

Yes, this seems to cover it.

@nigelmegitt
Copy link
Contributor

Note that at this time #739 does not add #length-version-2. Do we really need it?

skynavga added a commit that referenced this issue Jun 8, 2018
Add #length-root-container-relative feature (#718).
@skynavga skynavga added pr merged and removed pr open labels Jun 8, 2018
@skynavga skynavga removed their assignment Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants