Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of font* properties being applied to a paragraph. #785

Closed
skynavga opened this issue May 22, 2018 · 3 comments
Closed

Clarify meaning of font* properties being applied to a paragraph. #785

skynavga opened this issue May 22, 2018 · 3 comments

Comments

@skynavga
Copy link
Collaborator

The lack of specific text in the specification that explains the intended application of the following properties to a p element has resulted in certain misinterpretations:

  • fontFamily
  • fontShear
  • fontSize
  • fontStyle
  • fontWeight

The intent of having these apply to p is for the sole purpose of computing the default line height that applies for the purpose of formatting the paragraph. In XSL-FO, this is called the nominal-requested-line-rectangle.

Since the information that describes this usage is common for all five of these properties, we should employ only one description, and refer to it from all five attribute definitions.

Further, it may be necessary to add additional notes for some properties where there has developed a misunderstanding that the property should be applied to the block areas generated by a p rather than (or as well as) being applied to the glyph area descendants of these block areas. For example, the fontShear property is not intended to cause a shear transformation to occur on the block areas, but only on individual glyph area descendants of block areas.

See also #784 and a relevant email thread.

@skynavga
Copy link
Collaborator Author

Note well that we have previously encoded the semantic dependency of line height computation on the relevant font* properties in the algorithm found under tts:lineHeight.

@palemieux
Copy link
Contributor

The lack of specific text in the specification that explains the intended application of the following properties to a p element has resulted in certain misinterpretations:

None of these properties applied to p in TTML1, and it did not cause interoperability issues, so I do not understand why this was changed in TTML2.

skynavga added a commit that referenced this issue Jun 7, 2018
Clarify use of font* properties in resolving default line height (#785).
@skynavga skynavga removed their assignment Jun 7, 2018
@skynavga
Copy link
Collaborator Author

skynavga commented Jun 7, 2018

Merged early per WG resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants