Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing xml:base attribute. #804

Closed
skynavga opened this issue May 29, 2018 · 3 comments
Closed

Add missing xml:base attribute. #804

skynavga opened this issue May 29, 2018 · 3 comments
Labels
pr merged early substantive
Milestone
1ED-CR2

Comments

@skynavga
Copy link
Collaborator

skynavga commented May 29, 2018 •
edited
Loading

The xml:base attribute is missing from the following elements that employ a possibly relative <uri> valued attribute, e.g., src and xlink:href:

  • audio
  • data
  • font
  • image
  • span
  • source

In addition, at least the tt element should be able to specify a document-wide default base as well.
@skynavga skynavga added this to the CR2 milestone May 29, 2018
@skynavga skynavga self-assigned this May 29, 2018
skynavga added a commit that referenced this issue May 30, 2018
@skynavga
Add xml:base to core vocabulary (#804).
4d34ed9
@skynavga
Copy link
Collaborator Author

Upon further consideration, xml:base is needed for every element that permits condition or allows a descendant from the Metadata.class or a descendant that admits xml:base.

@skynavga skynavga mentioned this issue May 30, 2018
Merged
skynavga added a commit that referenced this issue May 30, 2018
@skynavga
Add xml:base to core attribute group (#804).
b12a6de
@cconcolato
Copy link
Contributor

Alternatively, we could simply say all relative URLs are resolved based on the document base URL.

skynavga added a commit that referenced this issue Jun 7, 2018
@skynavga
Merge pull request #808 from w3c/issue-0804-xml-base
e8e293f 
Add xml:base to core vocabulary (#804).
@skynavga skynavga removed their assignment Jun 7, 2018
@skynavga
Copy link
Collaborator Author

skynavga commented Jun 7, 2018

Merged early per WG resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr merged early substantive
Projects
None yet
Milestone
1ED-CR2
Development

No branches or pull requests
2 participants
@skynavga @cconcolato