Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CR Entities (#1190). #1192

Merged
merged 4 commits into from
Jan 9, 2020
Merged

Update to CR Entities (#1190). #1192

merged 4 commits into from
Jan 9, 2020

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Jan 6, 2020

Closes #1190.

@skynavga skynavga added this to the 2ED-CR milestone Jan 6, 2020
@skynavga skynavga self-assigned this Jan 6, 2020
@skynavga
Copy link
Collaborator Author

skynavga commented Jan 6, 2020

N.B. Set PR no earlier date in SoTD to March 17 based on PLH's Days to REC tool using CR=01/28/20 as start date.

@skynavga
Copy link
Collaborator Author

skynavga commented Jan 6, 2020

I had to make up language for exit criteria in the SoTD since there is no new feature in 2e. Also, one might ask if we really need an implementation report (IR) as such, but I suppose we can still do one (a "lite" version) that shows we passed the tests we have published. I created a placeholder IR.

nigelmegitt
nigelmegitt reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of new tests prepared in the w3c/ttml2-tests repository, either as merged or still open pull requests, which do exercise those substantive changes that can be tested, so I expect the IR not to be an empty set.

spec/status.xml Outdated Show resolved Hide resolved
@nigelmegitt nigelmegitt added agenda and removed agenda labels Jan 7, 2020
nigelmegitt
nigelmegitt approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that change sidesteps the question neatly.

@nigelmegitt
Copy link
Contributor

Marked as non substantive for IPR from ash-nazg.

@nigelmegitt nigelmegitt mentioned this pull request Jan 8, 2020
Closed
@skynavga skynavga merged commit 12985f8 into master Jan 9, 2020
@skynavga skynavga deleted the issue-1190-update-to-cr branch January 9, 2020 17:13
@skynavga skynavga removed their assignment Jan 9, 2020
himorin pushed a commit to himorin/ttml2 that referenced this pull request Jul 14, 2021
@skynavga @himorin
Address w3c#1192 (comment).
f164341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
no spec change pr merged early
Projects
None yet
Milestone
2ED-CR
Development

Successfully merging this pull request may close these issues.

Update SoTD and entities for 2ED CR publication.
2 participants
@skynavga @nigelmegitt