Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change {vw,vh} unit names to {rw,rh} (#181). #199

Merged
merged 1 commit into from Oct 12, 2016
Merged

Change {vw,vh} unit names to {rw,rh} (#181). #199

merged 1 commit into from Oct 12, 2016

Conversation

skynavga
Copy link
Collaborator

See #181.

@skynavga skynavga merged commit 3ffa374 into gh-pages Oct 12, 2016
@skynavga skynavga mentioned this pull request Oct 12, 2016
Closed
nigelmegitt
nigelmegitt reviewed Oct 12, 2016
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regenerated ED does not include the changes, i.e. http://w3c.github.io/ttml2/spec/ttml2.html#style-value-length currently still refers to vw and vh.

@skynavga
Copy link
Collaborator Author

Regenerated ED on gh-pages.

@nigelmegitt
Copy link
Contributor

Thanks, that's fixed it.

@skynavga skynavga deleted the issue-0181-viewport-units branch October 23, 2016 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt left review comments

Assignees
No one assigned
Labels
pr merged early
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skynavga @nigelmegitt