Issue 0230 vertical scripts #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o explicit use of UTR50 (#230).
nigelmegitt
requested changes
May 25, 2017
| affected. In addition, for purposes of bidirectional processing, this value causes all | ||
|
|
||
| <p>The presentation semantics of this style property apply only when a vertical | ||
| writing mode applies; therefore, if a horizontal writing mode applies, this style |
There was a problem hiding this comment.
It doesn't look like vertical writing mode and horizontal writing modes are defined either in TTML or in XSL 1.1. Suggest adding text to tts:writingMode to list which modes are considered horizontal and which vertical.
There was a problem hiding this comment.
Addressed in 0429c76.
nigelmegitt
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230.