Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [URI] to reference RFC3986 (#504). #505

Merged
merged 3 commits into from
Dec 23, 2017
Merged

Conversation

skynavga
Copy link
Collaborator

Closes #504.

@skynavga skynavga self-assigned this Dec 23, 2017
@skynavga skynavga added this to the Editor's CR Work List milestone Dec 23, 2017
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't quite understand the motivation for calling out SPACE character treatment, but I don't have any problem with doing so.

spec/ttml2.xml Outdated
<emph>Excluded US-ASCII Characters</emph>, do not appear in an unescaped form in the lexical representation of a <code>&lt;uri&gt;</code> value.</p></note>
<note role="clarification">
<p>For avoidance of doubt, characters designated to be excluded in a URI by <bibref ref="uri"/>, &sect;2,
<emph>Characters</emph>, and, more specifically, SPACE (U+0020) characters,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why call out SPACE characters particularly?

Copy link
Collaborator Author

@skynavga skynavga Dec 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RFC2396, the following were explicitly excluded in 2.3.4 (meaning they are escaped)

control     = <US-ASCII coded characters 00-1F and 7F hexadecimal>
space       = <US-ASCII coded character 20 hexadecimal>

while these are not explicitly excluded in the RFC3986 in section 2 (though perhaps one may consider this implied).

But I see that calling out SPACE alone is not sufficient, and I really want all XML whitespace characters, so I am elaborating this point in the newest commit in this branch, which perhaps you can approve.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never got the chance to approve this or not since you merged it so quickly, but I'm fine with it as luck has it. If you're going to ask me to approve though, it'd be polite to give me the opportunity to do so!

@skynavga skynavga removed the pr open label Dec 23, 2017
@skynavga skynavga merged commit 86464e0 into master Dec 23, 2017
@skynavga skynavga removed their assignment Dec 23, 2017
@skynavga skynavga deleted the issue-0504-update-uri-rfc branch March 9, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants