Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for ruby{Overflow,Overhang} (#494). #515

Merged
merged 2 commits into from Jan 10, 2018

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Dec 27, 2017

Closes #494.
Closes #493.
Closes #260.
Closes #259.
Closes #257.

@nigelmegitt
Copy link
Contributor

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the issue is resolved by this pull request but I am not able to review the detail of the new special semantics section at this time. Would appreciate it if any other WG member is able to do so.

@@ -12067,6 +12061,26 @@ base delimiter text delimiter =
<p>The inter-character positioning mode for ruby annotations, such as used with <emph>bopomofo</emph> characters,
is not supported by this version of this specification due to lack of market requirements.</p>
</note>
<div4>
<head>Special Semantics</head>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to review the special semantics section in detail - would appreciate e.g. @cconcolato 's review of this please.

@palemieux
Copy link
Contributor

I do not understand why "10.2.36.1 Special Semantics" was introduced as a separate section: the semantics do not seem anymore special than other ruby semantics.

@skynavga
Copy link
Collaborator Author

skynavga commented Jan 2, 2018

@palemieux because we do not in general specify default presentation behavior that, strictly speaking, is not related to tts:ruby; here, we essentially define default behavior that would have been derived from the initial values we had assigned to tts:{rubyOverflow,rubyOverhang}

@palemieux
Copy link
Contributor

@skynavga The reader has no idea that tts:{rubyOverflow,rubyOverhang} used to exist, and so the semantics directly apply to rendering of rubies, so there is really nothing special. Anyway I have approved the PR.

@skynavga
Copy link
Collaborator Author

skynavga commented Jan 2, 2018

well, you can consider it special in the sense that this behavior was not described in [1]

[1] http://www.w3.org/TR/2001/REC-ruby-20010531/

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@skynavga skynavga merged commit 6dabd79 into master Jan 10, 2018
@skynavga skynavga removed their assignment Jan 10, 2018
@skynavga skynavga deleted the issue-0494-defer-ruby-overflow branch March 9, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants