Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ttp:mediaOffset (#323). #536

Merged
merged 3 commits into from Jan 19, 2018
Merged

Remove ttp:mediaOffset (#323). #536

merged 3 commits into from Jan 19, 2018

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Jan 6, 2018

Closes #323.

@skynavga skynavga self-assigned this Jan 6, 2018
@skynavga skynavga added this to the Editor's CR Work List milestone Jan 6, 2018
@skynavga skynavga mentioned this pull request Jan 6, 2018
Closed
nigelmegitt
nigelmegitt reviewed Jan 10, 2018
View reviewed changes
spec/ttml2.xml
<loc href="#parameter-attribute-mediaOffset"><att>ttp:mediaOffset</att></loc> property.</p>
<p>The above formalisms assume that the begin time of the <loc href="#terms-root-temporal-extent">root temporal extent</loc> is related to the
begin time of a <loc href="#terms-related-media-object">related media object</loc>. If this assumption doesn't hold, then an additional offset
that accounts for the difference may be introduced when computing media time <code>M</code>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches TTML1 but I will raise a separate issue against this text on the basis that the temporal origin coordinates are assumed to be the same not just the begin times.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised as #550.

nigelmegitt
nigelmegitt approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is but have raised separate follow-on issues.

@skynavga skynavga merged commit 3c79949 into master Jan 19, 2018
@skynavga skynavga removed their assignment Jan 19, 2018
@skynavga
Copy link
Collaborator Author

See also #76.

@skynavga skynavga deleted the issue-0323-remove-media-offset-parameter branch March 9, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palemieux palemieux palemieux approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
substantive
Projects
None yet
Milestone
1ED-CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skynavga @palemieux @nigelmegitt