Remove auto value for rubyAlign (#249). #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skynavga
changed the title
skynavga
approved these changes
Jan 30, 2018
|
@skynavga I thought we had agreed, but indeed I can't find the minutes. This is related to Netflix's whitepaper in which we indicated that 'center' should be the default value. @nigelmegitt can we formally agree on that? |
|
@cconcolato I do not recall agreeing to remove Nevertheless, it does appear to be a possible resolution to the issue. If there is consensus on merging this pull request as a mechanism for resolving the issue then I think we should accept that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #249