-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ttp:version parameter attribute (#435). #606
Conversation
@@ -13006,9 +12920,6 @@ example.</p> | |||
<p>The <att>tts:textShadow</att> attribute is used to specify a style property that | |||
defines one or more text shadow decorations to apply to glyphs that are selected for <loc href="#terms-glyph-area">glyph areas</loc> generated | |||
by content flowed into a region.</p> | |||
<p>If both <loc href="#style-attribute-textOutline"><att>tts:textOutline</att></loc> and <att>tts:textShadow</att> attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this related to the version attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had previously thought that tts:textShadow
(a TTML2 feature) would replace tts:textOutline
(a TTML1 feature). We now understand it isn't a replacement (driven by version) but both apply independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this was driven by version and how this is related to ttp:version
but I think the change is good. Approving
@skynavga, just to make sure we have covered every aspect, I'm copying the results of your study of TTT and checking how this change affects them:
|
@cconcolato thanks for checking my TTT study; there are a few things I need to add/tweak to cover these points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great pull request, approving as is.
One question in my mind, possibly for a later change: should we also remove @version
from isd:isd
?
@nigelmegitt I reviewed |
@skynavga OK, I'm not sure about that but no objection from me to keep it in and moving on. |
Closes #435.