Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make begin times relative to the document temporal coordinate space (#512) #616

Merged
merged 5 commits into from
Feb 16, 2018

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Jan 31, 2018

Closes #512 and #550 and partly addresses #378. Resolves the ambiguity of whether the root temporal extent begins at the same time as the document's temporal coordinate space and moves the media timing informative section to appendix I.

Clarifies that body element and isd:isd begin and end times are relative to that coordinate space, rather than the root temporal extent, whose begin time is not necessarily the origin of the document's temporal coordinate space.

Closes #512. Resolves the ambiguity of whether the root temporal extent begins at the same time as the document's temporal coordinate space.
@palemieux
Copy link
Contributor

@palemieux
Copy link
Contributor

Couple of questions:

The root temporal extent, i.e., the time interval over which a document instance is active, has an implicit duration that is equal to the implicit duration of the body element of the document, if the body element is present, or zero, if the body element is absent.

Does this mean that the implicit duration of a document with no body is 0 even if some regions have tts:showBackground="always"? That does not seem right.

then the begin point is interpreted as the later of the beginning point of the document temporal coordinate space and the beginning point of the root temporal extent.

How does one compute the the beginning point of the root temporal extent?

@palemieux palemieux self-requested a review January 31, 2018 17:25
@nigelmegitt
Copy link
Contributor Author

Does this mean that the implicit duration of a document with no body is 0 even if some regions have tts:showBackground="always"? That does not seem right.

@palemieux It may do, however that is not a change introduced in this pull request - you might want to open a separate issue about that. It looks like this text doesn't take into account the rehoming of body under region.

How does one compute the the beginning point of the root temporal extent?

The only help the spec gives you (in the current ED or in this pull request) is "in relationship with some external application or presentation context" so I think that's defined out of band. The reason I added the "later of" construction is because a document with no begin attributes in practice begins whenever the presentation processor chooses to begin playing it, which is either at the document temporal origin or some time later, but by definition cannot be earlier.

@nigelmegitt
Copy link
Contributor Author

I realised this pull request also addresses #550, and updated the issue to match.

…-begin-times-relative-to-doc-time

Resolve the conflict introduced by the resolution to #378, allowing this pull request now to close #378.

This change moves the media timing informative section to Appendix I.

It is intended to match w3c/ttml1#334.
@nigelmegitt
Copy link
Contributor Author

nigelmegitt commented Feb 2, 2018

Brought in one of the changes needed also to address #378, i.e. moving the informative section on media timing.

Copy link
Collaborator

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior comment withdrawn.

Copy link
Collaborator

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a careful review, I have determined that, as currently formed, this PR does not break existing timing semantics. However, the new term introduced, [document temporal coordinate space] is defined by referring to ttp:timeBase, which returns to the former term, so there is a circular reference here leaving the reader to wonder what the new term really means. Also, the begin time of body is now changed to be the "later" of the beginning time of the [document temporal coordinate space] and the root temporal extent, but we do not know how these are related so as to resolve the meaning of "later". Notwithstanding these concerns, I am going to approve this, since, in my estimation it marginally improves the tools we may use to more precisely nail down these semantics in the future.

@skynavga skynavga merged commit 6a275e2 into master Feb 16, 2018
@skynavga skynavga modified the milestones: CR2, CR1 Feb 16, 2018
@skynavga skynavga deleted the issue-0512-begin-times-relative-to-doc-time branch March 9, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants