-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make begin times relative to the document temporal coordinate space (#512) #616
Conversation
Closes #512. Resolves the ambiguity of whether the root temporal extent begins at the same time as the document's temporal coordinate space.
Couple of questions:
Does this mean that the implicit duration of a document with no
How does one compute the the beginning point of the root temporal extent? |
@palemieux It may do, however that is not a change introduced in this pull request - you might want to open a separate issue about that. It looks like this text doesn't take into account the rehoming of
The only help the spec gives you (in the current ED or in this pull request) is "in relationship with some external application or presentation context" so I think that's defined out of band. The reason I added the "later of" construction is because a document with no |
I realised this pull request also addresses #550, and updated the issue to match. |
Partly addresses #378, and matches w3c/ttml1#334.
…-begin-times-relative-to-doc-time Resolve the conflict introduced by the resolution to #378, allowing this pull request now to close #378. This change moves the media timing informative section to Appendix I. It is intended to match w3c/ttml1#334.
Brought in one of the changes needed also to address #378, i.e. moving the informative section on media timing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior comment withdrawn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a careful review, I have determined that, as currently formed, this PR does not break existing timing semantics. However, the new term introduced, [document temporal coordinate space] is defined by referring to ttp:timeBase, which returns to the former term, so there is a circular reference here leaving the reader to wonder what the new term really means. Also, the begin time of body is now changed to be the "later" of the beginning time of the [document temporal coordinate space] and the root temporal extent, but we do not know how these are related so as to resolve the meaning of "later". Notwithstanding these concerns, I am going to approve this, since, in my estimation it marginally improves the tools we may use to more precisely nail down these semantics in the future.
Closes #512 and #550 and partly addresses #378. Resolves the ambiguity of whether the root temporal extent begins at the same time as the document's temporal coordinate space and moves the media timing informative section to appendix I.
Clarifies that body element and isd:isd begin and end times are relative to that coordinate space, rather than the root temporal extent, whose begin time is not necessarily the origin of the document's temporal coordinate space.