Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tts:luminanceGain to non-inheritable (#715). #716

Merged
merged 2 commits into from
May 10, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #715.

@skynavga skynavga added this to the CR2 milestone Apr 19, 2018
@skynavga skynavga self-assigned this Apr 19, 2018
@nigelmegitt
Copy link
Contributor

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me, given tts:luminanceGain applying only to region.

However, I wonder how it is supposed to work in practice - I might expect the value to vary in time on a subtitle by subtitle basis and therefore be applied to a p. That's a whole separate question though.

@palemieux
Copy link
Contributor

However, I wonder how it is supposed to work in practice - I might expect the value to vary in time on a subtitle by subtitle basis and therefore be applied to a p. That's a whole separate question though.

Using <set> to modulate the value?

@nigelmegitt
Copy link
Contributor

Using <set> to modulate the value?

OK if you're willing to take the authorial pain of having the content times completely separated from the luminanceGain times. Maybe that's okay, if the variation of luminanceGain over time can be algorithmically calculated base only on some processing of the video without reference to the subtitle text.

@skynavga skynavga merged commit 6fe7153 into master May 10, 2018
@skynavga skynavga removed their assignment May 10, 2018
@skynavga skynavga deleted the issue-0715-luminance-gain-inheritance branch June 28, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants