Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify fallback semantics for tts:textCombine (#725). #733

Merged
merged 2 commits into from
May 25, 2018
Merged

Specify fallback semantics for tts:textCombine (#725). #733

merged 2 commits into from
May 25, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #725.

@skynavga skynavga added this to the CR2 milestone May 11, 2018
@skynavga skynavga self-assigned this May 11, 2018
@skynavga skynavga requested a review from palemieux May 11, 2018 20:16
@nigelmegitt
Copy link
Contributor

Build available at https://rawgit.com/w3c/ttml2/issue-0725-text-combine-fallback-build/index.html

nigelmegitt
nigelmegitt approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@skynavga skynavga merged commit cf4bca3 into master May 25, 2018
@skynavga skynavga removed their assignment May 25, 2018
@skynavga skynavga deleted the issue-0725-text-combine-fallback branch June 28, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palemieux palemieux palemieux approved these changes

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
substantive
Projects
None yet
Milestone
1ED-CR2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skynavga @nigelmegitt @palemieux