Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text shadow offset to denote absolute (writing mode independen… #735

Merged
merged 3 commits into from
May 25, 2018

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented May 12, 2018

…t) direction (#723).

Closes #723.
Closes #722.

@skynavga skynavga added this to the CR2 milestone May 12, 2018
@skynavga skynavga self-assigned this May 12, 2018
spec/ttml2.xml Outdated
where positive denotes towards the right edge and negative towards the left edge,
the second <loc href="#style-value-length">&lt;length&gt;</loc> term denotes the offset
along the <loc href="#terms-vertical-axis">vertical axis</loc> dimension of the associated area,
where positive denotes towards the top edge and negative towards the bottom edge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A negative value places the shadow above the text, thereby matching CSS and matching the TTML convention where positive pixels on the vertical axis extend downwards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specified in https://www.w3.org/TR/css-backgrounds-3/#the-box-shadow which is referenced by https://www.w3.org/TR/css-text-decor-3/#text-shadow-property - it states:

2nd <length>
Specifies the vertical offset of the shadow. A positive value offsets the shadow down, a negative one up.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@nigelmegitt
Copy link
Contributor

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vertical lengths should be positive -> offset shadow downwards and negative -> offset shadow upwards.

spec/ttml2.xml Outdated
where positive denotes towards the right edge and negative towards the left edge,
the second <loc href="#style-value-length">&lt;length&gt;</loc> term denotes the offset
along the <loc href="#terms-vertical-axis">vertical axis</loc> dimension of the associated area,
where positive denotes towards the top edge and negative towards the bottom edge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specified in https://www.w3.org/TR/css-backgrounds-3/#the-box-shadow which is referenced by https://www.w3.org/TR/css-text-decor-3/#text-shadow-property - it states:

2nd <length>
Specifies the vertical offset of the shadow. A positive value offsets the shadow down, a negative one up.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@skynavga skynavga merged commit ef4cfa7 into master May 25, 2018
@skynavga skynavga removed their assignment May 25, 2018
@skynavga skynavga deleted the issue-0723-text-shadow-direction branch June 28, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants