Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe generically compliant processors that support only external … #755

Merged
merged 3 commits into from
Jun 4, 2018

Conversation

skynavga
Copy link
Collaborator

…profiles (#683).

Closes #683.

@skynavga skynavga added this to the CR2 milestone May 16, 2018
@skynavga skynavga self-assigned this May 16, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me but on reviewing, I see that on lines 2117 and 2136 (of this pull request branch) there is unchanged text: "A TTML content processor is a conformant TTML [transformation|presentation] processor"... but that we do not qualify the version of TTML that it applies to. Since the definitions include both DFXP conformance and TTML2 conformance, this is an extension relative to TTML1.

Suggestion: as part of this pull request we change that wording to "A TTML content processor is a conformant TTML2 [transformation|presentation] processor", i.e. introduce the digit 2 to the conformance claim requirement.

@skynavga
Copy link
Collaborator Author

skynavga commented May 17, 2018

@nigelmegitt No. It applies to any/all versions of TTML, including TTML1.

@palemieux palemieux removed their request for review May 27, 2018 15:11
@skynavga
Copy link
Collaborator Author

@nigelmegitt please re-check

@css-meeting-bot
Copy link
Member

The Working Group just discussed Describe generically compliant processors that support only external … ttml2#755, and agreed to the following:

  • SUMMARY: Review to continue offline
The full IRC log of that discussion <nigel> Topic: Describe generically compliant processors that support only external … ttml2#755
<nigel> github: https://github.com//pull/755
<nigel> Glenn: It's tricky - in some places we have to use TTML without qualification and in others
<nigel> .. it is relevant to qualify as TTML2.
<nigel> Nigel: Yes!
<nigel> .. I need a bit of offline time to check through that but I think it's fine.
<nigel> SUMMARY: Review to continue offline

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this resolves #683.

@skynavga skynavga merged commit 11a7f6b into master Jun 4, 2018
@skynavga skynavga removed their assignment Jun 4, 2018
@skynavga skynavga deleted the issue-0683-profile-support-optionality branch June 28, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants