Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove language that leads to incorrect inferences about style proper… #762

Merged
merged 2 commits into from
May 20, 2018
Merged

Remove language that leads to incorrect inferences about style proper… #762

merged 2 commits into from
May 20, 2018

Conversation

skynavga
Copy link
Collaborator

…ty derivation (#630).

Closes #630.

@skynavga skynavga added this to the CR2 milestone May 17, 2018
@skynavga skynavga self-assigned this May 17, 2018
@skynavga skynavga requested a review from nigelmegitt May 17, 2018 04:45
nigelmegitt
nigelmegitt requested changes May 17, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pointlessly removes a useful sentence from lots of places, where the basis for the claim in the sentence is based in the referenced text. I object to making this change.

nigelmegitt
nigelmegitt approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further discussion, the introductory text at the top of N.2.1 covers the equivalence, so it's harmless to remove these sentences.

@skynavga skynavga merged commit f544e34 into master May 20, 2018
@skynavga skynavga removed their assignment May 20, 2018
@skynavga skynavga deleted the issue-0630-attribute-derivation branch June 28, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt approved these changes

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
1ED-CR2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skynavga @nigelmegitt