Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit exceptions to ignoring element semantics with condition … #772

Merged
merged 5 commits into from
Jun 5, 2018

Conversation

skynavga
Copy link
Collaborator

…processing (#583).

Closes #583.

@skynavga skynavga added this to the CR2 milestone May 18, 2018
@skynavga skynavga self-assigned this May 18, 2018
@skynavga skynavga requested a review from nigelmegitt May 18, 2018 01:50
spec/ttml2.xml Outdated
purpose of determining which semantics are to be ignored when a <loc href="#content-value-condition">&lt;condition&gt;</loc> expression
value evaluates to <code>false</code>:</p>
<ulist>
<item><p>the <loc href="#semantics-timing">timing semantics</loc> of a <loc href="#terms-content-element">content element</loc> are not ignored;</p></item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content elements exclude region but @condition can be applied to region. I think this needs to be generalised to all elements that have timing semantics.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cbd9ce8.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Add explicit exceptions to ignoring element semantics with condition … ttml2#772, and agreed to the following:

  • SUMMARY: @skynavga to update to include references to the timed element term, then review to continue.
The full IRC log of that discussion <nigel> Topic: Add explicit exceptions to ignoring element semantics with condition … ttml2#772
<nigel> github: https://github.com//pull/772
<nigel> Glenn: I just did a commit last night to address comments.
<nigel> .. Nigel you pointed out that the use of content element wasn't sufficiently inclusive and
<nigel> .. suggested that we bring in all timed elements including region, so I introduced the
<nigel> .. term timed element. I had to review all the candidates for timed elements and decide
<nigel> .. what the distinguishing features were. I first thought timeContainer, but animate and set
<nigel> .. have begin and end but not timeContainer, since they don't have timed children.
<nigel> .. On the other hand everything had a begin, dur and end and I picked begin as a criterion.
<nigel> .. Then I changed content element ref to timed element so that should address your last
<nigel> .. comment and this should be ready to go.
<nigel> Nigel: Sounds good to me.
<nigel> Glenn: This just needs an approval - we've already passed 14 days on this one.
<nigel> Nigel: OK, interesting we don't have a class that corresponds to these.
<nigel> Glenn: Not in the spec - in TTV we have an IsTimedElement that does that, so implementations
<nigel> .. have to do it. I'm loathe to add another class just for this purpose. A definition should
<nigel> .. suffice.
<nigel> Nigel: Okay, I'll review.
<nigel> .. There are 16 uses of "timed element" in the spec.
<nigel> Glenn: I just noticed that, I'll update to add links to it.
<nigel> Nigel: Since we refer to this before, was it deemed to be an obvious concept or did we
<nigel> .. inherit it from SMIL?
<nigel> Glenn: I don't recall inheriting it from SMIL, but our usage would be different anyway.
<nigel> Cyril: Timed Element is a concept in SMIL I think.
<nigel> Glenn: It could be but the glossary section is very weak. In any case now that we have
<nigel> .. introduced timed element we should link those 16 places back to the definition now that
<nigel> .. we've added a term.
<nigel> Nigel: +1
<nigel> Nigel: Notices we should take care with 12.4
<nigel> Glenn: Yes
<nigel> Nigel: Aside from that, I think this looks good.
<nigel> SUMMARY: @skynavga to update to include references to the timed element term, then review to continue.

@skynavga
Copy link
Collaborator Author

@nigelmegitt implemented actions from SUMMARY above; should be good to go

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@skynavga skynavga merged commit 0e4c5f8 into master Jun 5, 2018
@skynavga skynavga removed their assignment Jun 5, 2018
@skynavga skynavga deleted the issue-0583-condition branch June 28, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants