Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tts:display 'inlineBlock' value to schemas; update rnc schemas to… #875

Merged
merged 3 commits into from Jul 4, 2018

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Jul 1, 2018

… use unix end of line convention (#874).

Closes #874.

@skynavga skynavga added this to the PR milestone Jul 1, 2018
@skynavga skynavga self-assigned this Jul 1, 2018
@skynavga skynavga requested a review from nigelmegitt July 1, 2018 16:10
Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love GitHub's review feature "Hide whitespace changes". Very useful here.
LGTM.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review this since every line has changed in one commit and the diff is completely unhelpful in this situation.

Sorry about this @skynavga but please could you close this and open a new pull request with two commits in, one for the EOL changes and one with the schema contents changes?

@skynavga
Copy link
Collaborator Author

skynavga commented Jul 3, 2018

@nigelmegitt see #875 (review)

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint @cconcolato !

@skynavga skynavga merged commit 6d09782 into master Jul 4, 2018
@skynavga skynavga removed their assignment Jul 4, 2018
@skynavga skynavga modified the milestones: PR, CR3 Jul 19, 2018
@skynavga skynavga deleted the issue-0874-display-inline-block branch October 4, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants