Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix derivation for 'tts:displayAlign' (#976). #997

Closed
wants to merge 1 commit into from
Closed

Fix derivation for 'tts:displayAlign' (#976). #997

wants to merge 1 commit into from

Conversation

skynavga
Copy link
Collaborator

Closes #976.

@skynavga skynavga added this to the PR milestone Sep 10, 2018
@skynavga skynavga self-assigned this Sep 10, 2018
nigelmegitt
nigelmegitt requested changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly surprised that @palemieux approved this without commenting here or at #976 (comment) so just putting a v temporary merge blocker in.

@skynavga skynavga removed their assignment Sep 11, 2018
@skynavga
Copy link
Collaborator Author

Closing without merger per imsc.js usage of justify-content.

@skynavga skynavga closed this Sep 11, 2018
@skynavga skynavga deleted the issue-0976-display-align-derivation branch October 4, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt requested changes

@palemieux palemieux palemieux approved these changes

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
1ED-PR
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skynavga @palemieux @nigelmegitt