Remove text selection from the dblclick default action - #328 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text selection begins on all browsers on the mousedown event (consistent with OS text selection), allowing extending the selection by continuing to drag. The dblclick event is too late to prevent text selection, so we should remove this default action to prevent confusion. Mousedown already includes text selection as a possible default action in the note.
mustaqahmed
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
This looks good, thanks. In addition to matching the spec with the de-facto behavior, this change also makes the spec consistent with itself 😄: the "Default Action" row in the top part of Section 5.3.4.4 already had "none"!
Asking for a related change elsewhere.
mustaqahmed
approved these changes
Jun 24, 2022
garykac
approved these changes
May 9, 2023
github-actions bot
added a commit
that referenced
this pull request
May 9, 2023
SHA: 01d97fd Reason: push, by garykac Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mangwu
added a commit
to mangwu/uievents-cn
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text selection begins on all browsers on the mousedown event (consistent
with OS text selection), allowing extending the selection by continuing
to drag. The dblclick event is too late to prevent text selection, so we
should remove this default action to prevent confusion.
Mousedown already includes text selection as a possible default action
in the note.
Closes #328
The following tasks have been completed:
Implementation commitment:
This is already the current behavior on WebKit, Chromium and Gecko.