Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WHATWG/INFRA 'is' definition for 'match' #80

Closed
himorin opened this issue Jun 10, 2021 · 1 comment · Fixed by #82
Closed

Use WHATWG/INFRA 'is' definition for 'match' #80

himorin opened this issue Jun 10, 2021 · 1 comment · Fixed by #82
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.

Comments

@himorin
Copy link

himorin commented Jun 10, 2021

In step 2., spec states

Otherwise, if mark is a DOMString, let end time be the value of the startTime attribute from the most recent occurrence of a PerformanceMark object in the performance entry buffer whose name matches the value of mark. If no matching entry is found, throw a SyntaxError.

which uses a text whose name matches the value of mark over user defined DOMString value. To use clear state, this text could refer is in WHATWG/INFRA instead of just matches. (also there is no clear definition of match in this spec.)

@himorin himorin added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label Jun 10, 2021
@npm1
Copy link
Contributor

npm1 commented Jun 11, 2021

Sure, we can change matches to is (PR welcome, or I'll create one next week)

npm1 added a commit that referenced this issue Jul 2, 2021
@npm1 npm1 closed this as completed in #82 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants