Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect non-empty check #90

Merged
merged 2 commits into from Apr 27, 2022
Merged

Remove incorrect non-empty check #90

merged 2 commits into from Apr 27, 2022

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Apr 26, 2022 •
edited by pr-preview bot

Fixes #89

Preview | Diff

@npm1 npm1 requested a review from yoavweiss April 26, 2022 15:28
yoavweiss
yoavweiss approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npm1 npm1 merged commit b9ff359 into gh-pages Apr 27, 2022
@npm1 npm1 deleted the nonempty branch April 27, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is unclear what "If startOrMeasureOptions is a non-empty PerformanceMeasureOptions object" means
2 participants
@npm1 @yoavweiss