Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the Multikey class #93

Merged
merged 5 commits into from
May 15, 2023
Merged

Added the Multikey class #93

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4e0bb8
Added the Multikey class
iherman Apr 21, 2023
ad2c842
Update vocab/security/vocabulary.yml
iherman Apr 22, 2023
39691ae
Using html syntax for link
iherman Apr 23, 2023
6dd1ffc
Update vocab/security/vocabulary.yml
iherman Apr 26, 2023
8594d44
Rolled back the change on Ed25519Signature2020
iherman Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion vocab/security/vocabulary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,18 @@ class:
- label: vc-data-integrity
url: https://www.w3.org/TR/vc-data-integrity/#dataintegrityproof

- id: Multikey
label: Multikey Verification Method
upper_value: sec:VerificationMethod
comment: Verification method to be used with the eddsa-2022 cryptographic suite. See the [EdDSA Cryptosuite v2022](https://www.w3.org/TR/vc-di-eddsa/#multikey) specification for further details.
iherman marked this conversation as resolved.
Show resolved Hide resolved
see_also:
- label: eddsa-2022
iherman marked this conversation as resolved.
Show resolved Hide resolved
url: https://www.w3.org/TR/vc-di-eddsa/#multikey

- id: Ed25519Signature2020
label: ED2559 Signature Suite, 2020 version
upper_value: sec:Proof
upper_value: sec:VerificationMethod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
upper_value: sec:VerificationMethod
upper_value: sec:Proof

deprecated: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why on which of the two statements?

For both cases I did not invent anything, just followed what is in the spec and/or in the other PR-s, that is all.

@msporny @dlongley ?

Copy link
Member

@msporny msporny Apr 25, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what @OR13 is saying is that Ed25519Signature2020 is a type of Proof? That, or he's asking why we're deprecating the signature type? I can't tell.

But, to be clear, Ed25519Signature2020 is specifically not a type of VerificationMethod -- verification methods are mechanisms used to determine if a proof is valid.

comment: T.B.D.

# These are the class definitions in the CCG documents that are not defined in the VCWG document; they are all deprecated
Expand Down