Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Check 2 Credentials Tests related to mapping to urls #24

Open
aljones15 opened this issue Jul 27, 2023 · 0 comments
Open

Double Check 2 Credentials Tests related to mapping to urls #24

aljones15 opened this issue Jul 27, 2023 · 0 comments
Assignees

Comments

@aljones15
Copy link
Collaborator

aljones15 commented Jul 27, 2023

Test/ Statement:
https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/04a307dc5e4d6686f3ca2f12054b5bba57050f3e/tests/10-vcdm2.js#L212-L226

VC:
https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/04a307dc5e4d6686f3ca2f12054b5bba57050f3e/tests/input/credential-type-unmapped-fail.json#L1-L14

Concern: this is probably failing because the type is not in a context and not because it's unmapped

VC:
https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/04a307dc5e4d6686f3ca2f12054b5bba57050f3e/tests/input/credential-type-url-ok.json#L1-L14

Concern: we generally don't use expanded forms in order to preserve interoperability with json only implementations, is this use of a url as a type ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants