-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification of example @context #71
Comments
@robdefeo I think the current spec text is more clarifying: https://w3c.github.io/vc-data-model/#dfn-context
That said, it does look like that test fixture had been incorrect. Things in the test suite have moved forward since then as well and that test file now contains content that should cause a failure. Thanks for reporting the bug! Please keep them coming! 😃 |
Ah, also, it looks like https://github.com/w3c/vc-data-model-2.0-test-suite/blob/main/tests/input/credential-type-unmapped-fail.json was specifically for testing unmapped types and has a value in the The updated fixture now further prevents confusion by clearing out the |
Thanks @BigBlueHat this helps a lot |
From the readme, there is this section.
However based on the test cases this is inconsistent, e.g. https://github.com/w3c/vc-data-model-2.0-test-suite/blob/main/tests/input/credential-type-unmapped-fail.json is
Since it contains
https://www.w3.org/ns/credentials/v2
the statementThis statement is incorrect based on the word
any
. What is the correct statement/implementation:any
should be replaced withboth
https://www.w3.org/ns/credentials/v2
should be removed from the listThe text was updated successfully, but these errors were encountered: