Group tests into sections. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigBlueHat
force-pushed
the
more-sections
branch
from
6e12e9f
to
5f6015f
Compare
aljones15
reviewed
Jun 10, 2024
aljones15
reviewed
Jun 10, 2024
| } | ||
| }); | ||
| // 1.3 Conformance https://w3c.github.io/vc-data-model/#conformance | ||
| beforeEach(addPerTestMetadata); |
aljones15
reviewed
Jun 10, 2024
aljones15
approved these changes
Jun 10, 2024
Removed confusing `vcApi` prefix.
The `body` values for test runs in the output JSON report (et al) are now accurate. Previously (using reportRow), they were all the same metadata adding function, so knowing what code had been used to test from the report was impossible.
Skipped Name & Description section as those are optional.
BigBlueHat
force-pushed
the
more-sections
branch
from
5f6015f
to
5d6be7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was getting very hard to understand the growing list of MUSTs relative to
the specification. The tests are now grouped into similarly named sections
with links in the code (at least) to those sections.
I plan to do more (likely in the upstream reporter) to make it possible to
link to the sections of the spec and provide basic descriptions of what the
tests are about.
Note: this one stacks on top of #73 which is still being polished.