Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC Vocabulary v2.0 does not have any term definitions #1117

Closed
andresuribe87 opened this issue May 8, 2023 · 6 comments
Closed

VC Vocabulary v2.0 does not have any term definitions #1117

andresuribe87 opened this issue May 8, 2023 · 6 comments
Assignees
Labels
before-CR pending close Close if no objection within 7 days

Comments

@andresuribe87
Copy link
Contributor

This section is empty. I'm not sure if this is intentional, but I do remember seeing it having multiple terms in the past.

Should the section be populated?

@melvincarvalho
Copy link

they are still here: https://www.w3.org/2018/credentials/vocabulary.jsonld

@iherman
Copy link
Member

iherman commented Jun 28, 2023

The issue was discussed in a meeting on 2023-06-28

  • no resolutions were taken
View the transcript

2.2. VC Vocabulary v2.0 does not have any term definitions (issue vc-data-model#1117)

See github issue vc-data-model#1117.

Brent Zundel: #1117 next.
… was a glitch with vocab term defs not showing up. Clicking on the link still seems to have the problem.

Orie Steele: I find the tooling for vocabulary, very hard to contribute too, fwiw.

Orie Steele: I wish I could be more helpful for this kind of thing.

Ivan Herman: seems to be a strange 'feature' in GitHub. It's a generated page. Terms are all in the page in GitHub but do not appear via github.io. but Manu might have something to comment. Tooling problem?

Manu Sporny: Pre-CR and needs to be fixed. Assigned to Ivan and Manu.

Brent Zundel: makes the assignement to Ivan and Manu.

@msporny
Copy link
Member

msporny commented Jul 4, 2023

Just looking into this issue a bit further... Echidna isn't publishing the latest vocabulary document because the Github build actions were never set up. Compare these build instructions (that build the Github Pages):

https://github.com/w3c/vc-data-model/blob/main/.github/workflows/gh-pages.yml#L32-L37

to these build instructions (that build the Echidna pages):

https://github.com/w3c/vc-data-model/blob/main/.github/workflows/echidna.yml

Also, note that we don't publish the vocabulary.html file at all via Echidna today. I suspect we're loading the Github pages one via a W3C proxy (or something to that effect). If we want to publish the vocabulary via W3C, which there seems to be consensus building to do so, we'll have to use a more involved Echidna set up (documented here):

https://w3c.github.io/spec-prod/#multiple-specs-in-same-repository

The next step is to see what file W3C TR space is serving when this URL is hit (@iherman will have to let us know): https://www.w3.org/2018/credentials/

... and then make sure that file is updated as a part of the Echidna publication process. The future state will have us publishing a "index.html" file as well as a "vocabulary.html" file.

@iherman
Copy link
Member

iherman commented Jul 4, 2023

fyi: I have communicated the htaccess file to @msporny; I prefer not to put it onto a public space...

@iherman
Copy link
Member

iherman commented Jul 14, 2023

This problem has been solved. Marking this issue as pending close.

@iherman iherman added the pending close Close if no objection within 7 days label Jul 14, 2023
@brentzundel
Copy link
Member

Fixed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before-CR pending close Close if no objection within 7 days
Projects
None yet
Development

No branches or pull requests

5 participants