New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor change to validFrom requested #1231
Comments
Tweaked replacement (NOTE: some URIs here and above point to If present, the value of the |
It applies to all the information in the VC -- so while this is true, saying this may cause people to think it doesn't apply to everything else too (e.g., the |
Re-revised. Better, @dlongley? If present, the value of the |
Yup, thanks, @TallTed! |
@David-Chadwick — What say you? Should the paragraph draft above go into the document(s)? |
No I dont agree with the second change unless the validUntil definition is similarly updated. It is important that both validFrom and validUntil are consistently worded. To remind you, this is the current text of validUntil If present, the value of the validUntil property MUST be an [XMLSCHEMA11-2] dateTimeStamp string value representing the date and time the credential ceases to be valid, which could be a date and time in the past. Note that this value represents the latest point in time at which the information associated with the credentialSubject property is valid. If a validFrom value exists, the validUntil value MUST be temporally greater than the validFrom value. You will note that my original change to validFrom was consistent with the current validUntil. So we either update both validFrom and validUntil with @dlongley 's proposed change, or neither. |
@David-Chadwick -- So, if I understand you correctly, you do agree with the latter
@dlongley (and anyone else) -- Please confirm whether you agree with the above, and if not, where your disagreement lies. |
@TallTed Yes, very good. Thanks |
Looks good to me. I guess we should probably adjust the MUST statements to allow for equivalent times as well (for whomever wants a VC to be valid for exactly one particular second):
And:
|
Now we just need a PR.... :-) |
The issue was discussed in a meeting on 2023-08-15
View the transcript2.7. Minor change to validFrom requested (issue vc-data-model#1231)See github issue vc-data-model#1231. Brent Zundel: next is 1231. minor change to validFrom. change to normative language so before CR. |
Unfortunately the version of the pr as at 22 Aug 23 still does not contain the required and agreed upon text |
PR #1250 was updated during the 2023-08-22 call. |
validFrom is currently defined as
If present, the value of the validFrom property MUST be a string value of an [ XMLSCHEMA11-2 ] combined date-time string representing the date and time the credential becomes valid, which could be a date and time in the future. Note that this value represents the earliest point in time at which the information associated with the credentialSubject property becomes valid.
The grammatical meaning of this paragraph is that the credential becomes valid at some point in the future, but it does not cater for the past. Please replace with
If present, the value of the validFrom property MUST be a string value of an [ XMLSCHEMA11-2 ] combined date-time string representing the date and time the credential either became valid, or will become valid i.e. a date and time in the future. Note that this value represents the earliest point in time at which the information associated with the credentialSubject property is valid.
The text was updated successfully, but these errors were encountered: