Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define algorithm for verification #1337

Closed
msporny opened this issue Nov 7, 2023 · 5 comments
Closed

Define algorithm for verification #1337

msporny opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels
before-CR pending close Close if no objection within 7 days pr exists

Comments

@msporny
Copy link
Member

msporny commented Nov 7, 2023

In issue #1285 (comment) @jyasskin wrote:

The serious issue is the one about defining the algorithm for verification. The definition of validation in this spec says that verification is in scope: "This specification is constrained to verifying verifiable credentials and verifiable presentations regardless of their usage. Validating verifiable credentials or verifiable presentations is outside the scope of this specification." To be clear, I'll encourage Google to formally object to this spec if an algorithm for verification isn't moved to Proposed REC at the same time as this spec. It's fine for this algorithm to call out to algorithms in other specs, or to look up subroutines in a registry, but the top-level algorithm needs to be defined. That's for two reasons:

  1. It's hard to be confident of interoperability if implementations have to gather verification requirements from many places across this and other specifications. If an implementation misses one or finds an extra one, it won't interoperate with implementations that found a different set of requirements.
  2. The security and privacy properties of VCs depend critically on the exact algorithm that a verifier follows. Privacy, for example, gets compromised if a verifier fetches an extra URL that happens to identify the credential that it's verifying. In order for security and privacy reviewers to check that this spec meets its goals, they have to be able to read the verification algorithm.
@msporny msporny added ready for PR This issue is ready for a Pull Request to be created to resolve it before-CR labels Nov 7, 2023
@msporny msporny self-assigned this Nov 7, 2023
@msporny
Copy link
Member Author

msporny commented Nov 9, 2023

PR #1338 has been raised to address this issue. This issue will be closed once PR #1338 has been merged.

@msporny msporny added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Nov 9, 2023
@jyasskin
Copy link
Member

I don't expect #1338 to be sufficient to close this. It's a good start, but it calls other algorithms that haven't been written yet, or which are missing important checks and type-consistency. This list is probably incomplete, but I see:

@msporny msporny added the pending close Close if no objection within 7 days label Dec 13, 2023
@iherman
Copy link
Member

iherman commented Dec 13, 2023

The issue was discussed in a meeting on 2023-12-13

  • no resolutions were taken
View the transcript

2.1. Define algorithm for verification (issue vc-data-model#1337)

See github issue vc-data-model#1337.

Brent Zundel: some have PRs exist.

Manu Sporny: this one needs to be closed, we merged related PRs, and filed follow up issues.

@msporny
Copy link
Member Author

msporny commented Dec 17, 2023

@jyasskin we're tracking improvements to the verification algorithm in more specific issues/PRs. The WG decided that it would be best to close this PR as the verification algorithm now exists (it's imperfect, but it's there). Refinements to the algorithm will be performed via other existing issues/PRs.

@iherman
Copy link
Member

iherman commented Dec 21, 2023

The issue was discussed in a meeting on 2023-12-20

  • no resolutions were taken
View the transcript

4.1. Define algorithm for verification (issue vc-data-model#1337)

See github issue vc-data-model#1337.

Brent Zundel: 1337 Define Alg for Verify. Main PR has been merged. I will close after call today.

@msporny msporny closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before-CR pending close Close if no objection within 7 days pr exists
Projects
None yet
Development

No branches or pull requests

3 participants