Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate verification from validation in verification algorithm #1376

Closed
msporny opened this issue Dec 7, 2023 · 5 comments
Closed

Separate verification from validation in verification algorithm #1376

msporny opened this issue Dec 7, 2023 · 5 comments

Comments

@msporny
Copy link
Member

msporny commented Dec 7, 2023

@OR13 would like us to separate verification from validation. This issue is being raised to track his concern.

@msporny
Copy link
Member Author

msporny commented Dec 7, 2023

It is not clear to me exactly what concrete specification text we need to write to address this concern. It might be related to this change suggestion.

@OR13 please edit the initial issue text to elaborate on what changes you'd like to see in the specification.

@OR13
Copy link
Contributor

OR13 commented Dec 7, 2023

@msporny the key concept I would like to see is "sharing of validation".

After verification, you have a JSON-LD document that might be conformant.

It should be possible to craft the language, such that the exact same algorithm applies to validating both verified data integrity proof secured and verified sd-jwt secured JSON-LD documents.

Status checks and schema checks can also be shared, assuming that is desirable.

@msporny
Copy link
Member Author

msporny commented Dec 10, 2023

@OR13 I believe PR #1381 addresses the concern you raised above (because it uses a suggestion you requested in a separate thread). Once PR #1381 is merged, this issue will be closed.

@iherman
Copy link
Member

iherman commented Dec 13, 2023

The issue was discussed in a meeting on 2023-12-13

  • no resolutions were taken
View the transcript

2.10. Separate verification from validation in verification algorithm (issue vc-data-model#1376)

See github issue vc-data-model#1376.

See github pull request vc-data-model#1381.

Brent Zundel: separate verification and validation, PRs exist.
… we have discussed, seems it is on a good trajectory.
… comments?

@msporny
Copy link
Member Author

msporny commented Dec 17, 2023

PR #1381 has been merged, closing.

@msporny msporny closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants