Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWS Examples and JOSE Consistency #470

Closed
jricher opened this issue Mar 19, 2019 · 5 comments
Closed

JWS Examples and JOSE Consistency #470

jricher opened this issue Mar 19, 2019 · 5 comments
Assignees
@dlongley
Labels
clarification Non-normative clarifications of spec text pending close Close if no objection within 7 days
Milestone
CR-Exit

Comments

@jricher
Copy link
Contributor

jricher commented Mar 19, 2019

The JWS examples in the LD Proofs section use the JWS Detached method from RFC 7797, while the JWT proofing section uses JWS from the original JOSE suite, with a specific requirement to use the JWT compact serialization. The detached serialization method is not mentioned in either this document or the LD-related documents linked from this specification.
@burnburn burnburn added the clarification Non-normative clarifications of spec text label Mar 19, 2019
@stonematt stonematt added this to the CR-Exit milestone Mar 21, 2019
@dlongley dlongley self-assigned this Mar 26, 2019
@msporny
Copy link
Member

msporny commented Apr 14, 2019

Ping @dlongley -- is a PR for this in process?

@dlongley
Copy link
Contributor

dlongley commented Apr 15, 2019 •
edited

@msporny, No, but I believe what @jricher requested is a simple "Note" after each RsaSignature2018 example that had an informative reference to its spec and that mentioned it used a JWS detached signature with an informative reference to the JWS spec.

@jricher
Copy link
Contributor Author

jricher commented Apr 16, 2019

@dlongley That would be sufficient for my concerns and would help developers reading through the examples.

@stonematt
Copy link
Contributor

From VCWG call on April 30, 2019:
RESOLUTION: Issue #470 should be addressed by making a set of non-normative changes to the specification that adds a simple note after each RsaSignature2018 example with an informative reference to that spec and that mentions it used a JWS detached signature with an informative reference to the JWS spec. Issue #470 should be closed after the PR is merged.

@stonematt stonematt added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Apr 30, 2019
msporny added a commit that referenced this issue May 6, 2019
@msporny
Explain and link to proof specs. Related to #470.
5fe226d
@msporny msporny mentioned this issue May 6, 2019
Merged
@msporny msporny removed the ready for PR This issue is ready for a Pull Request to be created to resolve it label May 7, 2019
@burnburn burnburn closed this as completed May 7, 2019
@brentzundel brentzundel added the pending close Close if no objection within 7 days label May 7, 2019
@msporny msporny removed the pr exists label May 7, 2019
@burnburn burnburn reopened this May 7, 2019
msporny added a commit that referenced this issue May 11, 2019
@msporny
Explain and link to proof specs. Related to #470.
f81bf38
@burnburn
Copy link
Contributor

Now it's been 7 days. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlongley dlongley

Labels
clarification Non-normative clarifications of spec text pending close Close if no objection within 7 days
Projects
None yet
Milestone
CR-Exit
Development

No branches or pull requests
6 participants
@msporny @jricher @dlongley @burnburn @stonematt @brentzundel