New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URIs or URLs for ids #748
Comments
I would say that the instances of This is likely true of all occurrences of |
This seems like it would be a substantive change, but does seem like something we could address within the purview of the V1.1 maintainence WG work. I've labeled it as such for now. |
Reminder, substantive changes that are in scope for the maintenance group should be labeled v1.2, per https://github.com/w3c/vc-data-model#process-overview-for-vc-data-model-pull-requests |
The issue was discussed in a meeting on 2021-09-08
View the transcript5.3. URIs or URLs for ids (issue vc-data-model#748)See github issue #748.
Brent Zundel: URIs or URLs for ids. We specify things as URLs in the spec David Chadwick: I have a comment. The standard is saying something should be a URI... This is not a breaking change. Brent Zundel: If an implementer is insisting that a credentialStatus is a URL and not a URI, and doing type checking like that, then their implementation would be flagging v1.0 URLs as incorrect. David Chadwick: Right, that would break implementations. I withdraw my comment. Charles Lehner: I can do it, considering I opened the issue. Brent Zundel: I will add you to the assignee list, and look forward to seeing the PR. Dave Longley: I don't know if anyone can tell looking at syntax whether something is a URI or URL... might not be something you could implement... given that, it might not be a substantive change. Brent Zundel: I appreciate that comment. Dave Longley: I don't feel very strongly either way, but thought it was worth making that comment. David Chadwick: I would not object to it in v1.1 Brent Zundel: It also has to do with - if we are asserting that this is an editorial change, we don't have to submit for editorial review.
|
Thanks @clehner for taking care of this |
The issue was discussed in a meeting on 2021-09-15
View the transcript5.3. URIs or URLs for ids (issue vc-data-model#748)See github issue #748.
Charles Lehner: This issue was about a variation between URLs and URIs and there's a PR open to address it Brent Zundel: We discussed earlier that a determination needs to be made around if this is errata or now David Chadwick: I don't think we have to resolve this today - can give Manu more time. Kyle Den Hartog: I agree, and expect he may be able to cover it, although he may be on vacation. |
The
id
property forcredentialStatus
,refreshService
, andevidence
objects are specified as URLs:Other
id
properties are specified as URIs:@context
property MUST be an ordered set where the first item is a URI with the value https://www.w3.org/2018/credentials/v1"Could the credential status id, refresh service ids, and evidence object ids be just URIs, like the other id properties? Or is it really meant that they should/must be URLs?
Also, should the
id
property of atermsOfUse
object or of a credentialissuer
object be expected to be a URI?Section § 4.2 Identifiers specifies the
id
property - but I am not sure if that is meant to apply to all uses ofid
properties, or only ones which specifically reference §4.2 or are described in §4.2 (like in Example 4).The text was updated successfully, but these errors were encountered: