Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example uses DriversLicense as evidence for a UniversityDegreeCredential #754

Closed
nikolockenvitz opened this issue Nov 19, 2020 · 2 comments · Fixed by #802
Closed

Example uses DriversLicense as evidence for a UniversityDegreeCredential #754

nikolockenvitz opened this issue Nov 19, 2020 · 2 comments · Fixed by #802
Assignees
Labels
editorial Purely editorial changes to the specification. errata Erratum for a W3C Recommendation maintenance issues that may be considered part of the work of the maintenance group pr exists

Comments

@nikolockenvitz
Copy link

Currently, the following example uses a DriversLicense as evidence for a UniversityDegreeCredential. I guess that is not intended and was just missed when updating all examples from "age over 21" to a UniversityDegreeCredential (e019298).

vc-data-model/index.html

Lines 2882 to 2889 in 44dc624

<span class="highlight">"evidence": [{
"id": "https://example.edu/evidence/f2aeec97-fc0d-42bf-8ca7-0548192d4231",
"type": ["DocumentVerification"],
"verifier": "https://example.edu/issuers/14",
"evidenceDocument": "DriversLicense",
"subjectPresence": "Physical",
"documentPresence": "Physical"
},{

A more suitable evidence may be found.

@wyc wyc added editorial Purely editorial changes to the specification. maintenance issues that may be considered part of the work of the maintenance group labels Feb 15, 2021
@brentzundel brentzundel added the PossibleErratum WG should determine if this is Errata label Mar 5, 2021
@kdenhartog kdenhartog added errata Erratum for a W3C Recommendation v1.1 and removed PossibleErratum WG should determine if this is Errata labels Jul 29, 2021
@kdenhartog kdenhartog self-assigned this Jul 29, 2021
@kdenhartog kdenhartog added this to the V1.1 Completion milestone Jul 29, 2021
@kdenhartog kdenhartog added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Aug 12, 2021
@kdenhartog kdenhartog removed this from the V1.1 Completion milestone Aug 13, 2021
@kdenhartog kdenhartog added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Aug 30, 2021
@kdenhartog kdenhartog linked a pull request Aug 30, 2021 that will close this issue
@kdenhartog
Copy link
Member

This has been addressed in PR #802 which has multiple approvals and was merged. Closing.

@iherman
Copy link
Member

iherman commented Nov 10, 2021

The issue was discussed in a meeting on 2021-10-27

  • no resolutions were taken
View the transcript

2.2. Example uses DriversLicense as evidence for a UniversityDegreeCredential (issue vc-data-model#754)

See github issue vc-data-model#754.

Kyle Den Hartog: quick report-out, no controversy, already addressed, cleaning up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Purely editorial changes to the specification. errata Erratum for a W3C Recommendation maintenance issues that may be considered part of the work of the maintenance group pr exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants