-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove broken links #1066
Remove broken links #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Objection to the PR, it would make just about every example in the spec use the "undefined terms" property, which would set a bad precedent.
Alternatives that could achieve consensus include:
- Create a "Getting Started" section that outlines how to get started by using the base context, and then layer semantic meaning after the developer has stabilized the terms they want to use.
- Use JSON-LD Contexts that are being used in pilot and production settings.
- Upgrade the base context to include terms like "name" and "website", or other generally useful properties for a credential subject, which could then be used in examples.
- Use JSON-LD Contexts from the VC Specs Directory.
The options above are being discussed in issue #1071 and a PR here #1064 (comment).
It is highly unlikely that there will be consensus to downgrade almost every example in the specification to, what is effectively, a bad practice in general.
Actually this fixes that problem (which exists in the spec today), it defines the terms using the default vocab. The current examples are malformed, and this PR is the simplest possible fix to them (since if defines their terms using the default context).
This does not fix the problem that the examples in the spec are malformed currently. Happy to address this in a separate PR.
Introduces further bias, and makes the examples in the spec more complicated.
This seems like maybe a path forward, make the examples simpler, so you don't need context complexity in them. You can also use the issuer defined terms to achieve this, that is exactly what the current PR does.
Introduces further bias, and makes the examples in the spec more complicated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that all the hyperlinks in our specification should be valid.
@Sakurann @brentzundel I would like some call time to discuss this and the JSON Schema PR: |
I am fine with the working group adding links that have consensus back to the examples, we can keep having that conversation here: It seems better to remove broken links first, and then add non broken links back. The links that are removed are not required and the examples are non normative. |
It seems to me harder to discover where those broken links were once they're removed, so I'd prefer to keep each (easy to locate) broken link until it is corrected, unless/until there's a determination that that link is not going to be corrected, for whatever reason. |
why does the WG need to discover old broken links? the one who is interested in fixing it will know where they are |
I'm closing this PR in favor of https://github.com/w3c/vc-data-model/pull/1111/files |
The issue was discussed in a meeting on 2023-05-03
View the transcript3.4. (pr vc-data-model#1066)See github pull request vc-data-model#1066. Brent Zundel: next up is PR 1066. Orie Steele: goals. Dave Longley: just quick clarification.
Dave Longley: and then issuer dependent vocabs but we should also say that this could be a risk.
Dave Longley: we should fix context instead of deleting them from examples. Brent Zundel: two paths possible.
Brent Zundel: agree that the links in the examples should work. Dave Longley: . See github pull request vc-data-model#1110. Dave Longley: to improve examples.
Brent Zundel: orie? Orie Steele: haven't had a chance to review it. |
did you mean #1110 ? |
Relies on issuer defined terms, which is the simplest way to define terms, and does not require the implementer to download several separate JSON-LD context files to make use of the examples in the spec.
^ this link is 404, and causes the examples in the spec to be invalid.
Preview | Diff