Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing remaining references to JSON #1182

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

Sakurann
Copy link
Contributor

@Sakurann Sakurann commented Jul 1, 2023

Clarifying that "There is no such thing as vc+json", addressing #1044 and preventing future confusion like in #1088 after it was merged. As part of that clarification, it references JSON-LD spec directly wrt the processing of @context, since if the base media type is vc+ld+json, it needs to be a valid JSON-LD.


Preview | Diff

index.html Outdated Show resolved Hide resolved
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
inline comments (<code>//</code>) and the use of ellipsis (<code>...</code>)
to denote information that adds little value to the example. Implementers are
cautioned to remove this content if they desire to use the information as
valid JSON or JSON-LD.
valid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
valid.
a valid document.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but noting that I'm a bit on the fence about removing this language, as that is how some implementations (including some of Digital Bazaar's processing pipelines), handle the VC as it is coming into or retrieved from our systems. We do, when it matters, do full JSON-LD processing, but that is not always necessary to perform. As long as we don't suggest that full JSON-LD processing is always required, this PR is fine. We might want to move a variation of this text to the implementation guide to ensure that developers know that it's ok to 1) ensure the order of the @context entries, and then 2) process as ordinary JSON, in the circumstances where you don't need to check the signature yet, or when the signature has been checked and you know that you're working w/ good data.

@OR13
Copy link
Contributor

OR13 commented Jul 5, 2023

Keep in mind that if +ld+json is not registered... none of what we are doing will matter... because there will be no general guidance on processing the media types we are requesting registration for.

w3c/json-ld-syntax#415

Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting changes until the structured suffixes details are resolved sufficiently to protect implementers from the confusion that would arise from removing these references while not defining how the suffixes are processed.

@Sakurann
Copy link
Contributor Author

Sakurann commented Jul 8, 2023

@OR13 what concrete details on the structured suffixes do you want to be resolved? multiple suffixes draft in IETF and how +ld+jwt is being processed is orthogonal to the changes in this PR and should block it.

@OR13
Copy link
Contributor

OR13 commented Jul 10, 2023

@Sakurann I guess you are right, the problem will be... if +ld+json is never registered, and its the only media type suffix we rely on, then our document should not advance.

I am approving, with the hope that does not happen.

@OR13 OR13 self-requested a review July 10, 2023 16:19
@msporny
Copy link
Member

msporny commented Jul 11, 2023

@Sakurann, waiting on a typo fix before merging: https://github.com/w3c/vc-data-model/pull/1182/files#r1249374162

@iherman
Copy link
Member

iherman commented Jul 11, 2023

The issue was discussed in a meeting on 2023-07-11

  • no resolutions were taken
View the transcript

1.7. removing remaining references to JSON (pr vc-data-model#1182)

See github pull request vc-data-model#1182.

Brent Zundel: this P.R removes differentiation between JSONLD and JSON. Has relatively broad approval.
… minor changes from manu, that I agree with.
… not sure this P.R calls for much discussion, but open to any if there are some.

@iherman
Copy link
Member

iherman commented Jul 11, 2023

The issue was discussed in a meeting on 2023-07-11

  • no resolutions were taken
View the transcript

1.7. removing remaining references to JSON (pr vc-data-model#1182)

See github pull request vc-data-model#1182.

Brent Zundel: this P.R removes differentiation between JSONLD and JSON. Has relatively broad approval.
… minor changes from manu, that I agree with.
… not sure this P.R calls for much discussion, but open to any if there are some.

@msporny
Copy link
Member

msporny commented Jul 12, 2023

@Sakurann, waiting on a typo fix before merging: https://github.com/w3c/vc-data-model/pull/1182/files#r1249374162

Actually, the suggestion is Editorial, and made by me, so I can just merge at this point and make the change, which is what I'll do.

@msporny
Copy link
Member

msporny commented Jul 12, 2023

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 659a03b into w3c:main Jul 12, 2023
1 check passed
@iherman
Copy link
Member

iherman commented Jul 12, 2023

The issue was discussed in a meeting on 2023-07-11

  • no resolutions were taken
View the transcript

1.7. removing remaining references to JSON (pr vc-data-model#1182)

See github pull request vc-data-model#1182.

Brent Zundel: this P.R removes differentiation between JSONLD and JSON. Has relatively broad approval.
… minor changes from manu, that I agree with.
… not sure this P.R calls for much discussion, but open to any if there are some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants