Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust media types to reflect updates #1190

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Jul 10, 2023

  • acknowledge that VP is a media type in the core data model
  • remove outdated text on VC-JWT

Preview | Diff

Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OR13 just to confirm. Those two media types apply to VC/VPs with/without proof?

Copy link
Contributor

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this clears up the groups current interpretation nicely.

@iherman
Copy link
Member

iherman commented Jul 11, 2023

The issue was discussed in a meeting on 2023-07-11

  • no resolutions were taken
View the transcript

1.11. Adjust media types to reflect updates (pr vc-data-model#1190)

See github pull request vc-data-model#1190.

Brent Zundel: P.R makes changes to the IANA considerations section.
… mentions application/vp+json alongside vc+json.
… seems a very simple P.R. Expect to be merged soon.

1 similar comment
@iherman
Copy link
Member

iherman commented Jul 12, 2023

The issue was discussed in a meeting on 2023-07-11

  • no resolutions were taken
View the transcript

1.11. Adjust media types to reflect updates (pr vc-data-model#1190)

See github pull request vc-data-model#1190.

Brent Zundel: P.R makes changes to the IANA considerations section.
… mentions application/vp+json alongside vc+json.
… seems a very simple P.R. Expect to be merged soon.

@msporny
Copy link
Member

msporny commented Jul 19, 2023

Editorial, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 94e5e27 into main Jul 19, 2023
1 check passed
@msporny msporny deleted the adjust-media-type-comment branch July 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants