Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reserved confidenceMethod property to the vocabulary — bis #1228

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

iherman
Copy link
Member

@iherman iherman commented Aug 4, 2023

This is, content-wise, the same PR as #1226, but starting fresh due to the merge problems. See #1226 (comment).

No need to re-review from scratch, just taking over #1226

Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one change requested

vocab/credentials/v2/vocabulary.yml Outdated Show resolved Hide resolved
Co-authored-by: Oliver Terbu <43441584+awoie@users.noreply.github.com>
vocab/credentials/v2/vocabulary.yml Outdated Show resolved Hide resolved
@iherman
Copy link
Member Author

iherman commented Aug 14, 2023

@msporny I took care of a merge conflict. I think it is now ready to be merged.

@msporny msporny merged commit 00469e3 into main Aug 15, 2023
2 checks passed
@msporny
Copy link
Member

msporny commented Aug 15, 2023

Substantive, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny deleted the iherman-add-confidenceMethod-vocabulary-bis branch August 15, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants