Removing unnecessary direction attributes #1446
Conversation
Referring to #1424, the edit removes the `@direction` information, except for the example that begins with numerals. (I am not 100% sure it is necessary for that example either, but keeping it there, to give at least one example of the key's usage).
iherman
requested review from
msporny,
selfissued and
decentralgabe
as code owners
index.html
Outdated
| "@value": "جامعة عامة تركز على أمثلة التدريس.", | ||
| "@language": "ar", | ||
| "@direction": "rtl" | ||
| "@language": "ar" |
There was a problem hiding this comment.
I left a comment on #1424. Notice that this "purely RTL string" does not display correctly in the diff--because it is in an LTR context and ends with a neutral character (.). The . is on the wrong side of the string.
There was a problem hiding this comment.
GitHub won't handle a suggestion on a line range that includes deleted/changed lines, so I'm making a change suggestion on 1719 above -- to move the . to the correct side of the string.
index.html
Outdated
| "@value": "جامعة عامة تركز على أمثلة التدريس.", | ||
| "@language": "ar", | ||
| "@direction": "rtl" | ||
| "@language": "ar" |
There was a problem hiding this comment.
GitHub won't handle a suggestion on a line range that includes deleted/changed lines, so I'm making a change suggestion on 1719 above -- to move the . to the correct side of the string.
|
Propose closing without merge; #1448 supersedes this PR. |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Referring to #1424, the edit removes the
@directionkey, except for the example that begins with numerals. (I am not 100% sure it is necessary for that example either, but keeping it there gives at least one example of the key's usage).Preview | Diff