Fixed terms of use #146
Closed
Fixed terms of use #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @David-Chadwick, this PR has conflicts and I can't fix the conflicts because the PR is from your personal Github repo. Do you want to fix the conflicts, or do you want me to do it? |
davidlehn
reviewed
Apr 30, 2018
| @@ -723,7 +726,7 @@ <h2>Terms of Use</h2> | |||
| "ageOver": 21 | |||
| }, | |||
| <span class="highlight">"termsOfUse": [{ | |||
| "type": "Policy", | |||
| "type": "< term of use type ID >", | |||
There was a problem hiding this comment.
Instead of using placeholder syntax here and below just put in an example value. These are just examples and everything else has example values.
davidlehn
reviewed
Apr 30, 2018
| @@ -755,8 +758,8 @@ <h2>Terms of Use</h2> | |||
| "proof": { ... } | |||
| }], | |||
| <span class="highlight">"termsOfUse": [{ | |||
| "type": "Policy", | |||
| "uid": "http://example.com/policy:4928", | |||
| "type": "< some unique terms of use ID >", | |||
There was a problem hiding this comment.
Same comment as above. Use a value vs placeholder syntax.
davidlehn
reviewed
Apr 30, 2018
| to determine how they may utilize the given information. Each term of use | ||
| is identified by a unique term of use identifier. | ||
| The precise contents of each term of use is determined by the specific | ||
| term of use definition. |
There was a problem hiding this comment.
This needs to be reworded. It's hard to follow and repetitive.
There was a problem hiding this comment.
Please see #170 for the reworded text.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is item vii) from PR#141
Preview | Diff