Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security section on token binding. Fixes #148. #173

Merged
merged 2 commits into from
May 17, 2018
Merged

Add security section on token binding. Fixes #148. #173

merged 2 commits into from
May 17, 2018

Conversation

msporny
Copy link
Member

@msporny msporny commented May 8, 2018 •
edited by pr-preview bot
Loading

dlongley
dlongley approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this says enough about what "token binding" is (perhaps a "for example" with a link to one or more of the IETF token binding drafts? https://github.com/TokenBinding/Internet-Drafts).

Otherwise seems ok.

@msporny
Copy link
Member Author

msporny commented May 15, 2018

perhaps a "for example" with a link to one or more of the IETF token binding drafts

Fixed in 58ac051.

@msporny
Copy link
Member Author

msporny commented May 15, 2018

Blocking on @jandrieu since this was his issue. Don't want to merge w/o him.

jandrieu
jandrieu approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@jandrieu jandrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@msporny msporny merged commit c6016d2 into gh-pages May 17, 2018
@msporny
Copy link
Member Author

msporny commented May 17, 2018

Thanks @jandrieu, merged.

@msporny msporny deleted the msporny-binding branch May 31, 2018 14:14
@jandrieu jandrieu mentioned this pull request Jun 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@jandrieu jandrieu jandrieu approved these changes

@stonematt stonematt Awaiting requested review from stonematt

@David-Chadwick David-Chadwick Awaiting requested review from David-Chadwick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msporny @dlongley @jandrieu