Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace identifier registry with Verifiable data registry. Clarify … #214

Merged
merged 22 commits into from Dec 12, 2018

Conversation

lovesh
Copy link
Member

@lovesh lovesh commented Aug 14, 2018

…that the verifiable data repositrory does not store subject identifiers or credentials but issuer identifiers, keys and some other data

Signed-off-by: lovesh harchandani lovesh.bond@gmail.com


Preview | Diff

…that the verifiable data repositrory does not store subject identifiers or credentials but issuer identifiers, keys and some other data

Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR suggests that we change the "identifier registry" terminology to "verifiable data repository".

Examples of "identifier registry" include: DID Ledgers and DNS/URLs. The concept being described by the PR is the "verifiable credential repository", which the holder typically uses. The group decided a long time ago to hide this detail as it's not necessary to understand /where/ the verifaible credentials are being stored other than "by the holder".

I suggest closing this PR as I think it misunderstands the model that we are currently working with in the group.

Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
@lovesh
Copy link
Member Author

lovesh commented Aug 21, 2018

@msporny We did not intend verifiable data repository to contain credentials. It is meant to hold DIDs, public keys, schema, revocation registries and similar public data. We find the term identifier registry to be narrow

@msporny
Copy link
Member

msporny commented Aug 21, 2018

We did not intend verifiable data repository to contain credentials. It is meant to hold DIDs, public keys, schema, revocation registries and similar public data. We find the term identifier registry to be narrow

Ahhh got it, thanks; that's definitely not clear from the PR.

Perhaps we need to rename it to cryptographic material registries, which includes supporting material that are used to cryptographically verify credentials (e.g., DID Ledgers, public key repositories, cryptographic schemas, and revocation lists)? Thoughts?

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful when changing this terminology. We'll need WG approval for this as it's not an editorial change... we're expanding the scope of the registry, which is fine, but I can't just process this as editorial without running it by the group.

index.html Outdated
@@ -253,11 +253,12 @@ <h3>Ecosystem Overview</h3>
<a>verifiable credentials</a> for processing.
Examples of verifiers include employers, security personnel, and websites.
</dd>
<dt><a>identifier registry</a></dt>
<dt><a>Verifiable data repository</a></dt>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to something like "cryptographic material registry"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think schema is not a cryptographic material, neither are identifiers like a DID, do you agree? Can we call it public data regsitry so that it is clear that it contains no holder specific data

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msporny Do you agree?

Copy link
Member

@msporny msporny Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public data registry is too vague. Schemas are cryptographic material -- they are used as input to cryptographic functions to perform calculations. Specifically, schemas enable byte streams to be created in a deterministic fashion, so yes, I would classify schemas as cryptographic material for the purposes of the VC Data Model and ecosystem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am re-inclining to Verifiable Data Repository. Verifiable communicates the intent, cryptographic seems like a blanket term. As an example, seed to a PRF is a cryptographic data but not something we want to put in the repository

index.html Outdated
A role a system may perform by mediating the creation and verification of
<a>subject</a> identifiers. Examples of identifier registries include
corporate employee databases, government ID databases, and distributed ledgers.
Mediates the creation and verification of <a>issuer</a> identifiers, keys and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry is not only for issuers, it's for subjects in general of which issuers are a subtype.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

index.html Outdated
</li>
<li>
The <a>subject</a> trusts the <a>issuer</a> to issue true (i.e., not false)
<a>credentials</a> about the subject, and to revoke them quickly when
appropriate.
</li>
<li>
The <a>holder</a> trusts the <a>repository</a> to store the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be removed. This is talking about the holder's 'credential repository'... not the cryptographic material registry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added back

Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
@lovesh lovesh changed the title Replace identifier registry with verifiable data repository. Clarify … Replace identifier registry with Public data regsitry. Clarify … Aug 27, 2018
index.html Outdated
@@ -602,8 +603,9 @@ <h1>Trust Model</h1>
risk assessment of the verifier.
</li>
<li>
All entities trust the <a>identifier registry</a> to be incorruptible and
to be a correct record of which identifiers belong to which <a>entities</a>.
All entities trust the <a>Public data repository</a> to be un-corruptible and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo un-corruptible => incorruptible ... or maybe just use tamper-evident instead like we do elsewhere?

Copy link
Member Author

@lovesh lovesh Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, tamper-evident it is

index.html Outdated
@@ -254,11 +254,12 @@ <h3>Ecosystem Overview</h3>
<a>verifiable presentations</a> for processing.
Examples of verifiers include employers, security personnel, and websites.
</dd>
<dt><a>identifier registry</a></dt>
<dt><a>Public data repository</a></dt>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public => public (throughout)

Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
Signed-off-by: lovesh harchandani <lovesh.bond@gmail.com>
@lovesh lovesh changed the title Replace identifier registry with Public data regsitry. Clarify … Replace identifier registry with Verifiable data registry. Clarify … Sep 4, 2018
@brentzundel
Copy link
Member

Can this PR move forward? @msporny has requested it be discussed by the group before it can be merged:

I can't just process this as editorial without running it by the group.

What is the next step here?

@David-Chadwick
Copy link
Contributor

One minor comment I have is what is the difference between repository and registry?
Of the top of my head, I would say that a repository is less restrictive than a registry in that the former might allow duplication (e.g. two different entities to store the same ID), whereas the latter would not as it is registering them.
I would therefore prefer the term verifiable data registry, as @lovesh said it would be in his comment above. But the current PR text uses repository instead.

@msporny
Copy link
Member

msporny commented Oct 16, 2018

Still no significant discussion among the group. Perhaps we can discuss this at W3C TPAC 2018?

@jandrieu
Copy link
Contributor

We use repositories for where data is stored, such as identity hubs or wallets.

Maybe there is a better choice than registries for recording the unique namespacing of identifiers, but repositories definitely conflates registries with storage locations.

Signed-off-by: Brent <brent.zundel@gmail.com>
changed repository to registry
@msporny
Copy link
Member

msporny commented Oct 26, 2018

The result of the discussion at W3C TPAC 2018 was that we pull the PR in after no more than 7 days of bike shedding on the word "schema".

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor bike shedding changes that I hope will work for everyone.

@@ -257,10 +257,10 @@ <h3>Ecosystem Overview</h3>
<a>verifiable presentation</a> that proves the holder possesses the required verifiable credentials with certain characteristics.
Examples of verifiers include employers, security personnel, and websites.
</dd>
<dt><a>identifier registry</a></dt>
<dt><a>Verifiable data registry</a></dt>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concrete suggestion: Change to "Cryptographic Data Registry"

Reasoning: The data isn't always verifiable (e.g. federated or DHT-style systems). In almost every case, the registry does contain data that is used in cryptographic processes of one kind or another.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless there is significant consensus for "Cryptographic Data Registry," or a lot of opposition to "Verifiable data registry" I would prefer to keep "Verifiable data registry" for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean that a "DID Ledger" is a type of "Verifiable Data Registry"... which conflates the way "Verifiable" is used in the VC data model spec, and the general usage of the word. It doesn't feel quite right to me because some DID Ledgers, like Veres One, store data (like service descriptions, that aren't "Verifiable" in the "Verifiable Credentials" sense of the word, so it's a strange fit.

I think the bigger issue is that a federated/mirrored corporate system would also be a "Verifiable Data Registry", but some of that information is not verifiable (i.e., it is only valid because the corporation says it's valid)... but the fact that all of these systems hold cryptographic data in one form or another is the common denominator here.

Keep in mind that this started out as an "Identifier Registry" because the block had a specific purpose. We are now expanding that purpose and have to be careful to not expand too far, or pick the wrong word.

We need more input on this, perhaps on a call (because I don't think the people that may have something to say about this are paying attention to code commit comments), perhaps via a run off poll because we're bike shedding at this point and it'll go on forever w/o some finality to the name change. We had to bike shed this name early on and did an IRV poll to get finality that time. We should do this again so we can get this PR sorted quickly and into the spec.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verifiable Data Registry is inaccurate. The credential itself contains the verifiable data.

I think this registry potentially contains a broad variety of data that is used for verification, such as service descriptions, schemas, credential definitions, DIDs, revocation information, etc.

How does the name Verification Material Registry sound? I think it reflects the scope and intent for which it will be used.

Copy link
Member

@msporny msporny Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Verification Material Registry" is probably the most accurate thing so far, so I'd be fine w/ that ... and now we're squarely in "we need to ask the WG" territory. I'll try to draft up an Instant Runoff Vote for this... We have:

  • Verification Material Registry
  • Cryptographic Data Registry
  • Verification Data Registry
  • Cryptographic Material Registry
  • Verifiable Data Registry (do we still want to keep this option for the vote?)

... any other contenders that folks want to put forward?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification material registry is fine with me as well.

Copy link
Contributor

@dlongley dlongley Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned that we're perhaps losing the original main intent for the registry which was to be an identifier registry. I understand that there are other registry needs as well (e.g. Sovrin credential schemas) -- and that many of them are related to verification. We want to include those, but not at the expense of others. Perhaps we can just call this system component "Registries" and then talk about what different types of registries might be out there in the prose?

What's important, IMO, is that they are seen as independent components in the ecosystem, i.e. they are not tightly coupled to the issuer, verifier, or holder, allowing for agility and greater decentralization.

index.html Outdated
<dd>
A role a system may perform by mediating the creation and verification of <a>issuer</a> identifiers,
keys and other relevant data required to use verifiable credentials. Some configurations may require correlatable
keys and other relevant data like schemas, revocation registries, etc. required to use verifiable credentials. Some configurations may require correlatable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concrete suggestion: Change "schemas" to "data validation schemas"

Reasoning: The term "schema" is too broad and has led to confusion in the group.

terms.html Show resolved Hide resolved
@David-Chadwick
Copy link
Contributor

LGTM

@msporny
Copy link
Member

msporny commented Nov 27, 2018

There is now a document that is collecting options for an Instant Run-off Vote that starts in ~60 hours:

https://docs.google.com/document/d/1dCPGKiW9uqVd1X_Ye6BCFt4qzRRGjPNfTuYEQKIZk6k/edit#

I hope that everyone is happy with themselves, this is why we can't have nice things. 😜

@brentzundel
Copy link
Member

@msporny from what I can see, there are no more merge conflicts. Let me know if there are any more thing I should resolve.

@msporny
Copy link
Member

msporny commented Dec 12, 2018

I tried to resolve the merge conflicts here, but failed miserably. Lots of merges and edits. Let me know if you get this fixed @brentzundel ... if not, a new PR would probably be easier to merge in.

@dlongley dlongley merged commit bdd4d99 into w3c:gh-pages Dec 12, 2018
@dlongley
Copy link
Contributor

@brentzundel -- I took care of it, we're good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants