New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on syntactic sugar. See #207 and #268. #255
Conversation
index.html
Outdated
another entity. This ensures proper cryptographic separation between the data | ||
graph provided by each <a>issuer</a> and the one provided by the | ||
<a>presenter</a> to ensure the provenance of the information for each graph | ||
is preserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to say more here about how a "claim" is really a separate graph of statements made by the issuer via a credential... and that JSON-LD uses sugar to keep the JSON syntax simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really the wrong way to go. I do not believe we should have claims in the RDF. see #207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@David-Chadwick, I'm currently exploring if it's possible to drop the @graph
container (to at least see if it's a viable option) by checking to see what kind of JSON-LD frame would properly separate the claim information from the proof information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done, thus resolving @David-Chadwick's concern.
Fixed. |
You need to be able to make statements about statements -- that's what graph containers enable. If you can't do this, the information model becomes non-deterministic and the whole ecosystem falls down. Graph containers (or a concept like it) are not optional. Keep in mind that developers don't need to know any of this. They just slot the data in the right place. I added this PR because a number of people wanted to know the details... and now that the details have been added, it sounds like you're saying: The details are not necessary.
VCs don't always contain just one cryptographic proof. For example, VCs that are issued by a group (like a board of directors on a particular vote) may contain N signatures.
While I agree with a subset of what you say above... I need concrete text that I can apply to this PR to make progress. |
a005732
to
9ed1551
Compare
I believe I have addressed all of @David-Chadwick's concrete concerns. Merging. If a mistake was made, an issue or PR to fix would be appreciated. |
Addresses #268 and #207.
Preview | Diff